Skip to content

Implement AST -> HIR generics propagation in delegation#151864

Open
aerooneqq wants to merge 10 commits intorust-lang:mainfrom
aerooneqq:delegation-generics-propagation
Open

Implement AST -> HIR generics propagation in delegation#151864
aerooneqq wants to merge 10 commits intorust-lang:mainfrom
aerooneqq:delegation-generics-propagation

Conversation

@aerooneqq
Copy link
Contributor

@aerooneqq aerooneqq commented Jan 30, 2026 •
edited
Loading

This PR adds support for generics propagation during AST -> HIR lowering and is a part of #118212.

Nearest future work:

  • Late-bound lifetimes
  • impl Trait params in functions
  • Proper propagation of parent generics when generating method call
  • Fix diagnostics duplication during lowering of user-specified types
  • Support for recursive delegations
  • Self types support reuse <u8 as Trait<_>>::foo as generic_arguments2
  • Decide what to do with infer args reuse Trait::<_, _>::foo::<_>

r? @petrochenkov

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2026

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Member

Kivooeo commented Jan 30, 2026

would it be possible to split this pr to commits?

@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 30, 2026

would it be possible to split this pr to commits?

@aerooneqq is sitting in the same office with me, we'll figure out how to review this better.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
fmease
fmease reviewed Jan 30, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq aerooneqq force-pushed the delegation-generics-propagation branch from 94fa69b to a6d9e63 Compare February 4, 2026 14:42
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq aerooneqq force-pushed the delegation-generics-propagation branch from a6d9e63 to 9033bc5 Compare February 5, 2026 15:18
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Feb 5, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
REPOSITORY                                   TAG       IMAGE ID       CREATED       SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   10 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/double_parens.rs ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/empty_docs.rs ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/eager_transmute.rs ... ok
---
..............................................     (146/146)

======== tests/rustdoc-gui/search-filter.goml ========

[ERROR] line 48: Error: The CSS selector "#search-tabs .count.loading" still exists: for command `wait-for-false: "#search-tabs .count.loading"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=test>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aerooneqq @rustbot @rust-log-analyzer @Kivooeo @petrochenkov @fmease